Skip to content

[PE-83] fix: reset text and background color in issue description #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pushya22 merged 1 commit into from
Jan 7, 2025
Merged

[PE-83] fix: reset text and background color in issue description #6336

pushya22 merged 1 commit into from
Jan 7, 2025

Conversation

@aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Jan 7, 2025 •
edited by coderabbitai bot
Loading

Description

This PR fixes reset text and background color bug on issue descriptions.

Cause of the bug- Wrong argument being passed to the text and background color handlers.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Bug Fixes
    • Improved color reset functionality in the editor's bubble menu color selector to ensure consistent color command handling.

@aaryan610 aaryan610 added this to the v0.24.0 milestone Jan 7, 2025
@aaryan610 aaryan610 requested a review from rahulramesha January 7, 2025 07:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2025 •
edited
Loading

Walkthrough

The pull request introduces a subtle modification in the BubbleMenuColorSelector component's event handling for color reset buttons. The change involves wrapping undefined in an object when passing color reset commands, ensuring the command function receives the expected parameter structure. This adjustment maintains the component's existing logic while aligning the method of invoking color reset commands for both text and background color items.

Changes

File Change Summary
packages/editor/src/core/components/menus/bubble-menu/color-selector.tsx Modified onClick handlers for text and background color reset buttons to pass undefined wrapped in an object

Suggested labels

🎨UI / UX

Suggested reviewers

  • SatishGandham

Possibly related PRs

Poem

🎨 A Rabbit's Color Reset Rhyme 🐰

In the realm of colors, a tiny tweak
Undefined wrapped, no longer weak
Bubble menu's hue, now precise and neat
A code dance that makes the changes sweet
Hop along, little change, take flight! 🌈

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 906d095 and ed3064f.

📒 Files selected for processing (1)
  • packages/editor/src/core/components/menus/bubble-menu/color-selector.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: lint-admin
  • GitHub Check: lint-web
  • GitHub Check: lint-space
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/editor/src/core/components/menus/bubble-menu/color-selector.tsx (3)

74-74: LGTM! Fixed text color reset.

The change correctly wraps undefined in an object to match the expected parameter structure of the command function, aligning with how color selection is handled.

97-97: LGTM! Fixed background color reset.

The change correctly wraps undefined in an object to match the expected parameter structure of the command function, aligning with how color selection is handled.

74-74: Great fix for the color reset functionality!

The changes properly align the reset command structure with the color selection command structure, ensuring consistent parameter passing. This should resolve the color reset issues in the issue description.

Also applies to: 97-97

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit ae657af into preview Jan 7, 2025
13 of 14 checks passed
@pushya22 pushya22 deleted the fix/editor-color-reset branch January 7, 2025 12:34
This was referenced Jan 7, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 28, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Palanikannan1437 Palanikannan1437 Palanikannan1437 approved these changes

@rahulramesha rahulramesha Awaiting requested review from rahulramesha

Assignees

No one assigned

Labels

🐛bug Something isn't working ✍️editor 🌐frontend

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aaryan610 @Palanikannan1437 @pushya22